Skip to content

[Backport] fix: correct series file entries and sort patch keys in deb target#1048

Merged
cpuguy83 merged 1 commit into
project-dalec:release/0.20from
burak-ok:burak/backport_1024
Apr 28, 2026
Merged

[Backport] fix: correct series file entries and sort patch keys in deb target#1048
cpuguy83 merged 1 commit into
project-dalec:release/0.20from
burak-ok:burak/backport_1024

Conversation

@burak-ok
Copy link
Copy Markdown
Contributor

This is a backport of #1024

Fix two bugs in the deb patch handling:

  1. sourcePatchesDir wrote the target source name instead of the patch source name to the series file, causing incorrect documentation.
  2. createPatchScript iterated over the Patches map without sorting, causing non-deterministic patch application order unlike the RPM target which sorts keys.

Add unit tests for both issues.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Fix two bugs in the deb patch handling:
1. sourcePatchesDir wrote the target source name instead of the patch
   source name to the series file, causing incorrect documentation.
2. createPatchScript iterated over the Patches map without sorting,
   causing non-deterministic patch application order unlike the RPM
   target which sorts keys.

Add unit tests for both issues.

Signed-off-by: Burak Ok <burakok@microsoft.com>
@cpuguy83 cpuguy83 merged commit 35b8688 into project-dalec:release/0.20 Apr 28, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants